-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't iterate over files and folders that should be ignored #1023
Comments
Maybe this fixes it in eslint 4? |
Hmm not sure. I'm not sure why caching should fix it, but I know almost nothing about eslint internals, so I could very well be wrong. |
AFAIK |
@ematipico Correct. I think what @Flet was hinting at was if the solution to this might come automatically when at some point standard is upgraded to 4.x |
@watson could you try with |
@Flet doesn't seem to fix it unfortunately: |
hmmm hang on... might have spoke too soon. Let me just check something |
Aww, was worth a shot :( |
I'm having this same issue. Fix is traversing ignored paths and complaining with a exit code 1 |
Can confirm, I have the same issue with a very-very-very large (almost cyclic) |
The issue seems related to |
LOL amazing issue report |
Nice thank you for digging @serls :) |
I took at stab at this and found that this is a combination of a few issues. As @searls pointed out, the issue is inside deglob.
Suggested solution:
@feross what do you think of this? |
My preferred solution would be to update deglob to behave like the glob module or I realize it could be seen a breaking change, but one person's breaking change is another's patch fix! Based on the popularity of using Is that on the table? |
I'm removing |
Woohoo! Thanks @feross! |
This will be fixed in |
In a project of mine, I have a build directory that quickly gets really large. It's ignored via
.gitignore
, so standard doesn't fail on it, but it still runs through all files in the directory. It results in a running time of 13 seconds as opposed to 1 second without the build directory.I know this have been discussed before (#680) and it seems to be a "feature" inherited from eslint. But I'm opening this issue to hopefully start a discussion on how to work around this or how to potentially fix it (either in standard or in eslint).
The text was updated successfully, but these errors were encountered: