Don't run on Node.js versions less than 8.10.0 #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinusU
approved these changes
Mar 15, 2020
|
My approach in #1495 doesn't work. Instead, I'll add the minimum version we think we should work on to the |
|
I think that this approach (minimum as indicated by That's how I do it in many of my packages as well :) |
This was referenced Apr 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLint uses the
s(dotAll) flag for regular expressions which isn't supported in Node.js versions earlier than 8.10.0.I made a similar PR for when the spread operator was introduced in Node.js v8.6.0: #1418
Once this lands, I'll rebase #1495 to make sure we test early Node.js versions in CI.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
I changed the minimum Node.js version where
standardwill run to be 8.10.0 (was 8.6.0).Which issue (if any) does this pull request address?
closes #1494
closes #1455
Is there anything you'd like reviewers to focus on?
Consider if this is actually a breaking change. If so we need to roll back the version of eslint instead of this. However, I think this be accepted so it's not breaking given the circumstances.