Don't run on Node.js versions less than 8.6.0 #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint uses the spread operator which isn't supported in Node.js versions earlier than 8.6.0.
|
14.3.1 |
|
@feross Does the I can publish the release if you like, but just haven't been paying attention to the convention lately 😅 |
It means that I released it on npm. Except in this case, I didn't actually do the release! The build was failing so I went to fix that and forgot to actually publish. Fixed now! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLint uses the spread operator which isn't supported in Node.js versions earlier than 8.6.0.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Previously the cli would just check that the major version was 8 or above before continuing. This change now also looks at the minor version to ensure that the full version is v8.6.0 or above.