-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow string concatenation when using __dirname and __filename (no-path-concat) #403
Comments
7.5% of packages either don't work on Windows, or their tests don't work on Windows. I think we should enable this, because even though this will make people change their code, this is actually a real problem – a programmer error — in their code that should be fixed. |
After fixing up all the packages that I have push access to, only 21/427 (5%) are failing. All the cases I fixed up were real cases where that code wouldn't work in a cross-platform way on Windows. I think this is a good rule. |
ACK. I think this change makes sense. |
Released in standard 6.0.0. |
See: http://eslint.org/docs/2.0.0/rules/no-path-concat
Replace this:
With this:
From eslint docs:
The text was updated successfully, but these errors were encountered: