Skip to content

Conversation

@hden
Copy link
Owner

@hden hden commented Mar 17, 2016

update devDependency & comply with latest coding standard

update devDependency & comply with latest coding standard
@julianlam
Copy link

Hey @hden -- two thoughts

  1. How come you made a pull request to a repo you own? 😆
  2. Is it really standard to call out to path instead of using string concatenation? In NodeBB, I typically just use string concat when it's very obviously in the same directory (e.g. fs.access(__dirname + '/foo.bar', noop);), but path.join() when it's up a directory or otherwise complicated (e.g. path.join(__dirname, '../../node_modules/async/library.js');)

Just looking to learn more about how others code 😄

@hden
Copy link
Owner Author

hden commented Mar 17, 2016

@julianlam Thanks for asking.

  1. I just want the CI to run before merging to master. 😆
  2. By standard I meant feross/standard, the coding style. Please see Disallow string concatenation when using __dirname and __filename (no-path-concat) standard/standard#403 for underlying rationales.

@julianlam
Copy link

Interesting! Thank you for sharing.

hden added a commit that referenced this pull request Mar 17, 2016
@hden hden merged commit 666e9d9 into master Mar 17, 2016
@hden hden deleted the bunp branch March 17, 2016 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants