Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Cocoapods 1.6 #328

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Use Cocoapods 1.6 #328

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
710fed3
Use Cocoapods 1.6
dfed Oct 30, 2024
706a93f
Allow warnings
dfed Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Allow warnings
  • Loading branch information
@dfed
dfed committed Oct 30, 2024
commit 706a93f32a90829de40c1596dc41212c065e9e44
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
- name: Select Xcode Version
run: sudo xcode-select --switch /Applications/Xcode_16.app/Contents/Developer
- name: Lint Podspec
run: bundle exec pod lib lint --verbose --fail-fast --swift-version=6.0
run: bundle exec pod lib lint --verbose --fail-fast --swift-version=6.0 --allow-warnings # Cocoapods v1.6 now warns about potential naming colisions. We can fix this in the next breaking change.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warnings:

    - WARN  | xcodebuild:  /Users/runner/work/Valet/Valet/Sources/Valet/Accessibility.swift:21:13: warning: public enum 'Valet.Accessibility' shadows module 'Accessibility', which may cause failures when importing 'Valet' or its clients in some configurations; please rename either the enum 'Valet.Accessibility' or the module 'Accessibility', or see https://github.com/apple/swift/issues/56573 for workarounds
    - WARN  | xcodebuild:  /Users/runner/work/Valet/Valet/Sources/Valet/Valet.swift:22:20: warning: public class 'Valet.Valet' shadows module 'Valet', which may cause failures when importing 'Valet' or its clients in some configurations; please rename either the class 'Valet.Valet' or the module 'Valet', or see https://github.com/apple/swift/issues/56573 for workarounds

This is indeed a thing. I doubt we'll fix Valet.Valet, but Valet.Accessibility could be renamed pretty easily in the next breaking change.

carthage:
name: Carthage
runs-on: macOS-15
Expand Down