Use Cocoapods 1.6 #328
Merged
Use Cocoapods 1.6 #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfed
commented
Oct 30, 2024
| @@ -47,7 +47,7 @@ jobs: | |||
| - name: Select Xcode Version | |||
| run: sudo xcode-select --switch /Applications/Xcode_16.app/Contents/Developer | |||
| - name: Lint Podspec | |||
| run: bundle exec pod lib lint --verbose --fail-fast --swift-version=6.0 | |||
| run: bundle exec pod lib lint --verbose --fail-fast --swift-version=6.0 --allow-warnings # Cocoapods v1.6 now warns about potential naming colisions. We can fix this in the next breaking change. | |||
There was a problem hiding this comment.
The warnings:
- WARN | xcodebuild: /Users/runner/work/Valet/Valet/Sources/Valet/Accessibility.swift:21:13: warning: public enum 'Valet.Accessibility' shadows module 'Accessibility', which may cause failures when importing 'Valet' or its clients in some configurations; please rename either the enum 'Valet.Accessibility' or the module 'Accessibility', or see https://github.com/apple/swift/issues/56573 for workarounds
- WARN | xcodebuild: /Users/runner/work/Valet/Valet/Sources/Valet/Valet.swift:22:20: warning: public class 'Valet.Valet' shadows module 'Valet', which may cause failures when importing 'Valet' or its clients in some configurations; please rename either the class 'Valet.Valet' or the module 'Valet', or see https://github.com/apple/swift/issues/56573 for workarounds
This is indeed a thing. I doubt we'll fix Valet.Valet, but Valet.Accessibility could be renamed pretty easily in the next breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.