Skip to content

feat(expander): Add star expander for SELECT * and RETURNING * (PostgreSQL, MySQL, SQLite) #4203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 8 commits into from
Dec 1, 2025
Merged

feat(expander): Add star expander for SELECT * and RETURNING * (PostgreSQL, MySQL, SQLite) #4203

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5f89eb2
feat(postgresql): Add star expander for SELECT * and RETURNING *
kyleconroy Nov 30, 2025
475cfcf
feat(expander): port expander to use internal AST types
kyleconroy Dec 1, 2025
3b8932c
feat(expander): add MySQL support and use ColumnGetter interface
kyleconroy Dec 1, 2025
dd128fe
fix(expander): use valid MySQL syntax for edge case tests
kyleconroy Dec 1, 2025
e7836b8
feat(expander): add SQLite support
kyleconroy Dec 1, 2025
3c31da6
refactor(expander): use PrepareContext in SQLColumnGetter
kyleconroy Dec 1, 2025
ffc490b
refactor(expander): use native ncruces/go-sqlite3 API for column names
kyleconroy Dec 1, 2025
f1bbc6e
refactor(expander): use forked MySQL driver and fix list formatting
kyleconroy Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(expander): use valid MySQL syntax for edge case tests 
MySQL doesn't support unqualified `*` mixed with other columns (e.g.,
`SELECT *, *` or `SELECT id, *, name`). These are valid PostgreSQL
but invalid MySQL syntax.

Update MySQL tests to use table-qualified stars which are valid:
- `SELECT authors.*, authors.*` instead of `SELECT *, *`
- `SELECT id, authors.*, name` instead of `SELECT id, *, name`

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
  • Loading branch information
@kyleconroy @claude
kyleconroy and claude committed Dec 1, 2025
commit dd128fe5f11d3fd4444d05cc511c75c7d5fc6559
13 changes: 10 additions & 3 deletions internal/x/expander/expander_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,16 @@ func TestExpandMySQL(t *testing.T) {
query: "SELECT authors.* FROM authors",
expected: "SELECT authors.id,authors.name,authors.bio FROM authors;",
},
{
name: "double table qualified star",
query: "SELECT authors.*, authors.* FROM authors",
expected: "SELECT authors.id,authors.name,authors.bio,authors.id,authors.name,authors.bio FROM authors;",
},
{
name: "star in middle of columns table qualified",
query: "SELECT id, authors.*, name FROM authors",
expected: "SELECT id,authors.id,authors.name,authors.bio,name FROM authors;",
},
{
name: "count star not expanded",
query: "SELECT COUNT(*) FROM authors",
Expand All @@ -280,9 +290,6 @@ func TestExpandMySQL(t *testing.T) {
query: "SELECT COUNT(*), name FROM authors GROUP BY name",
expected: "SELECT COUNT(*), name FROM authors GROUP BY name", // No change
},
// Note: "double star" and "star in middle of columns" tests are skipped for MySQL
// because the intermediate query formatting produces invalid MySQL syntax.
// These are edge cases that rarely occur in real-world usage.
}

for _, tc := range tests {
Expand Down
Loading