Skip to content

feat(expander): Add star expander for SELECT * and RETURNING * (PostgreSQL, MySQL, SQLite) #4203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 8 commits into from
Dec 1, 2025
Merged

feat(expander): Add star expander for SELECT * and RETURNING * (PostgreSQL, MySQL, SQLite) #4203

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5f89eb2
feat(postgresql): Add star expander for SELECT * and RETURNING *
kyleconroy Nov 30, 2025
475cfcf
feat(expander): port expander to use internal AST types
kyleconroy Dec 1, 2025
3b8932c
feat(expander): add MySQL support and use ColumnGetter interface
kyleconroy Dec 1, 2025
dd128fe
fix(expander): use valid MySQL syntax for edge case tests
kyleconroy Dec 1, 2025
e7836b8
feat(expander): add SQLite support
kyleconroy Dec 1, 2025
3c31da6
refactor(expander): use PrepareContext in SQLColumnGetter
kyleconroy Dec 1, 2025
ffc490b
refactor(expander): use native ncruces/go-sqlite3 API for column names
kyleconroy Dec 1, 2025
f1bbc6e
refactor(expander): use forked MySQL driver and fix list formatting
kyleconroy Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(expander): port expander to use internal AST types 
Move expander from internal/engine/postgresql/expander to internal/x/expander
and port it to use the internal AST types instead of pg_query nodes.

Key changes:
- Use internal AST types (*ast.SelectStmt, *ast.InsertStmt, etc.)
- Use astutils.Search for star detection
- Use ast.Format instead of pg_query deparse
- Add Parser interface for dependency injection
- Add test cases for COUNT(*) (should not be expanded)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
  • Loading branch information
@kyleconroy @claude
kyleconroy and claude committed Dec 1, 2025
commit 475cfcf744d9fca5e8fbb1edcf8300b1542b5f83
Loading
Loading