Add selenium tests for alert pages #34 #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Test for check any elements visibility , editability and response - Induced bugs in alerts htmls to check if the test gets picked or not
Add selenium tests for alert pages siglens#34
shyam2520
requested review from
sunitakawane,
sonamgupta21,
nkunal and
AndrewHess
as code owners
|
@sonamgupta21 please review |
selenium-tests/tests/alerts-test.js
Outdated
| let driver; | ||
| const chromeOptions = new chrome.Options() | ||
|
|
||
| // chromeOptions.addArguments('--headless'); |
There was a problem hiding this comment.
Please uncomment this line.
There was a problem hiding this comment.
I have made the changes for the same
selenium-tests/tests/alerts-test.js
Outdated
| @@ -0,0 +1,189 @@ | |||
| // const {Builder, By, Key, until} = require('selenium-webdriver'); | |||
|
|
|||
| // (async function example() { | |||
There was a problem hiding this comment.
Please remove the commented code.
There was a problem hiding this comment.
I have made the changes for the same
|
Looks good! |
|
I have updated the branch |
sonamgupta21
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wrote test cases for alerts.html page to check if the elements in the page exist and if so are they editable and clickable.
Fixes #34(#34)
Testing
Induced bugs in alerts.html to check if the selenium script runs catches those, reviewers can comment on any element in the page to check if the script catches or not.
Checklist:
Before marking your pull request as ready for review, complete the following.
goimports -w ..