Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add selenium tests for alert pages #34 #1

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Add selenium tests for alert pages #34 #1

merged 4 commits into from
Nov 21, 2023

Conversation

shyam2520
Copy link
Owner

@shyam2520 shyam2520 commented Nov 21, 2023 •
edited
Loading

Description

Wrote test cases for alerts.html page to check if the elements in the page exist and if so are they editable and clickable.

Fixes siglens#34(siglens#34)

Testing

Induced bugs in alerts.html to check if the selenium script runs catches those , reviewers can comment any element in the page to check if the script catches or not .

Checklist:

Before marking your pull request as ready for review, complete the following.

  • I have self-reviewed this PR.
  • I have removed all print-debugging and commented-out code that should not be merged.
  • I have added sufficient comments in my code, particularly in hard-to-understand areas.
  • I have formatted the code, if applicable. For Go, I have run goimports -w ..

ashutoxh and others added 4 commits November 21, 2023 11:32
@ashutoxh
Fixed README.me link for sigscalr-client (#110)
9e68cd3
@Zhifei-Li
Index scroll issue (#113)
50bdd2b 
* add tests

* index scroll issue
@kaushik-manivannan
Replace Log Search Icon in Side Navbar (#108) (#115)
daf9011 
* Replace Log Search Icon in Side Navbar (#108)

Also, modified the Pull Request Lifecycle section in the CONTRIBUTING.md file.

* Fixed make pr command

* Removed private files
@sai-vivekanand
UI : Show Contact Name in Delete Confirmation Popup #101 (#112)
58a7d5f 
* siglens UI issue commit

* making the contact name BOLD
@shyam2520 shyam2520 merged commit 4e7e5b7 into shyam2520:develop Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add selenium tests for alert pages
5 participants
@shyam2520 @sai-vivekanand @ashutoxh @Zhifei-Li @kaushik-manivannan