DOC Add triage team section in "About us" page #17305
Conversation
| passwd = getpass.getpass("Password or access token:\n") | ||
| auth = (user, passwd) | ||
| token = getpass.getpass("access token:\n") | ||
| auth = (user, token) |
There was a problem hiding this comment.
passwords are deprecated: https://developer.github.com/changes/2020-02-14-deprecating-password-auth/
| The following people are active contributors who also help with triaging | ||
| issues, PRs, and general maintenance: |
There was a problem hiding this comment.
@cmarmo please make sure the description does you justice!
| core_devs = set(core_devs) | ||
| members = set(members) | ||
| emeritus = members.difference(core_devs) | ||
| triage_team = set(['cmarmo']) |
There was a problem hiding this comment.
We can't get this from GitHub api?
There was a problem hiding this comment.
@NicolasHug thanks for your proposition. I, obviously, personally appreciate that. ❤️
I have a general comment as in #17011. It's not about having justice for me here. It's about defining new roles in the development community. Other projects are in the process of doing that (see for example the Astropy new role of Software Operational Support Specialist), the presence of the github triaging role itself is probably also the evidence that this kind of activity is more and more needed. To be honest, I'm quite under the impression that the current solution (and this PR then) is a bit ad-hoc, aimed to "give me justice" and not to accept the importance of such a role. Adding the triaging team to the website will make contributors ask about this new role and how they can eventually be accepted in this role.... there are already contributors trying to help in the same way as I am, especially after the sprints. This could not just be about me looking for acknowledgement.
If @scikit-learn/core-devs think that they need a new role, my suggestion is that the Roles and Responsibilities page should be updated first: roles and responsibilities of a triaging team should be defined.... and there is no hurry, on my side I will just continue in doing what I'm doing now... even if sometimes I would be more comfortable if my role would be better defined... this is the price for freedom I suppose... ;)
| members.remove('sklearn-wheels') | ||
| members -= {'sklearn-ci', 'sklearn-lgtm', 'sklearn-wheels'} | ||
| # remove Olivier from triage team | ||
| triage_team -= {'ogrisel'} |
There was a problem hiding this comment.
Is there a way for not displaying people already present in the core dev team, rather than hardcode one name?
No, absolutely. Just to clarify my intent here: I'm not trying to "do you a favor", or to make you happy, or anything (well I'm not trying to make you unhappy either). My only intent is to give credit where it's due, because that's what we do as a project. It so happens that this role (and thus you) deserves some. And since the idea was mentioned in #17011 (comment) and no one had taken action so far, I just decided to do it, as a maintenance task, and as part of my job. Maybe my phrasing "please make sure this does you justice" wasn't the best one. I asked your feedback specifically on the description, to make sure it is accurate. I wanted to make sure that the description I wrote wasn't downplaying the triaging role in any way (you can never be too careful).
Yes, this would be great. This could be a great topic for tomorrow's meeting ;), if you feel like it |
There was a problem hiding this comment.
Thanks for picking this up @NicolasHug . I'd say this is a good start. I completely agree with @cmarmo on defining the roles, and this to me is a step towards that direction.
|
Thanks for the reviews, merging |
NicolasHug
changed the title
|
That's cool. |
This PR adds a triage team section in the "About us" page.