Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT fix generate_authors_table.py #17011

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

adrinjalali
Copy link
Member

A part of #17010.

I think we should also either put @cmarmo in the authors list, or have a triage team section.

@adrinjalali adrinjalali added this to the 0.23 milestone Apr 23, 2020
@jnothman
Copy link
Member

I think we should also either put @cmarmo in the authors list, or have a triage team section.

Seeing as there is a nomination and voting process for people to appear on this page, we probably need some formal way to recognise core people that aren't devs...?

@cmarmo
Copy link
Contributor

cmarmo commented Apr 23, 2020

I think we should also either put @cmarmo in the authors list, or have a triage team section.

Seeing as there is a nomination and voting process for people to appear on this page, we probably need some formal way to recognise core people that aren't devs...?

@adrinjalali, thanks for proposing this, that's really nice... ❤️. But I partly agree with @jnothman, in the sense that I'm not a core-dev and I don't think I will be one in the coming months. My role here is still WIP, let's say... I think that the team should start thinking a bit more seriously about the need (or not) of a project management approach and eventually define new roles for that. Let's wait some more releases.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but what is this fixing? I see no difference except for the potential typo in @jeremiedbb 's name

@NicolasHug
Copy link
Member

For @cmarmo we can at least add a "Triage team" section in the People page between the core devs and the emeritus ones?

@adrinjalali
Copy link
Member Author

This fixes mostly something in the script. I had to fix the same issue last time during the release, so I though I rather fix it on the repo.

@jnothman jnothman merged commit 1b119c4 into scikit-learn:master Apr 27, 2020
@jnothman
Copy link
Member

Can construct the triage team section separately

@adrinjalali adrinjalali deleted the 0.23/authors branch April 27, 2020 18:31
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants