Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rosnode info show topic types of unconnected subscribers #2366

Open
wants to merge 1 commit into
base: noetic-devel
Choose a base branch
from
Open

Make rosnode info show topic types of unconnected subscribers #2366

wants to merge 1 commit into from

Conversation

Sanoronas
Copy link

When running a node which has unconnected Subscribers rosnode info is unable to infer topic type.
In contrast rostopic info is able to resolve this.

  • change rosnode info to use master.getTopicTypes() instead of master.getPublishedTopics('/')
  • rename pub_topics variable to topic_types to match new content

peci1
peci1 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@peci1 peci1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've tested this locally.

Theoretically, this might introduce much higher traffic on systems with many topics, but I guess it's not a big problem because rosnode info is more a diagnostic tool than something that should be used as a part of a final system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peci1 peci1 peci1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sanoronas @peci1