roslaunch exit code 0 even if requried node died with non-zero exit code #919

sd1074 · 2016-10-28T17:23:02Z

Currently (at least in my indigo installation), if one of the nodes launched by roslaunch dies due to an error or from a signal, roslaunch is able to catch that and report, but its exit code is still 0.
This makes if hard to verify whether roslaunch was successful or not.
I am not sure if it's a bug report or a feature request, but I think propagating required node's exit code to ros roslaunch exit code would be a useful imp.

The described behavior was confirmed here:
http://answers.ros.org/question/219115/exit-code-of-roslaunch-shutdown-on-node-death/

It can also be easily verified with a simple launch file:

<?xml version="1.0"?>
<launch>
    <node pkg="turtlesim" type="turtlesim_node" name="turtlesim_node" output="screen" required="true" />
</launch>

run it, then kill the node:
$ kill -9 <TURTLESIM_NODE_PID>

roslaunch then shuts down with:

================================================================================REQUIRED process [turtlesim_node-1] has died!
process has died [pid 4832, exit code -9, cmd /opt/ros/indigo/lib/turtlesim/turtlesim_node __name:=turtlesim_node __log:=/home/USER/.ros/log/a1339242-9d30-11e6-b60e-9c4e36311474/turtlesim_node-1.log].
log file: /home/sd/.ros/log/a1339242-9d30-11e6-b60e-9c4e36311474/turtlesim_node-1*.log
Initiating shutdown!
================================================================================
[turtlesim_node-1] killing on exit
shutting down processing monitor...
... shutting down processing monitor complete
done

The reported error code is:

$ echo $?
0

I believe that even if not via exit code, there should be some easy mechanism to check whether roslaunch succeeded or failed (based on the required node exit code).

The text was updated successfully, but these errors were encountered:

TeeJayR · 2017-01-03T18:59:52Z

One could directly check the exit code of the started nodes as roslaunch prints the node's pid, but I don`t see a way to do this programmatically and agree that roslaunch should forward the exit code of the node. But what if multiple nodes have been started by roslaunch?

alspitz · 2018-07-19T23:30:19Z

At least if a required node dies, I think it would be better if roslaunch returned any non-zero exit code instead of 0.

xkortex · 2019-11-22T18:17:03Z

This makes it challenging to containerize ROS nodes or stacks.

 [nodename] process has died [pid 136, exit code -6 ...

is what I see when a node has an unhandled exception, then the container goes down,

containername- exited with code 0

No obvious way to intercept this, either. Can't trust presence of stderr, as some applications will roslog error but then recover.

LukeAI · 2020-05-11T11:02:45Z

Was there a conclusion to this? I also want to be able to programmatically check whether or not a roslaunch failed. @dirk-thomas I see you added the enhancement tag - do you know if there is some way of getting the exit code of the child node?

dirk-thomas · 2020-05-13T21:10:27Z

I assume not at the moment. Please consider to contribute a pull request to enable this.

xkortex · 2020-05-17T19:13:00Z

I might be able to do it if someone could point roughly in the stack where to look or what keywords to grep for.

…process at least for a regular parent launch process, child and remote processes need looking at. May solve ros#919 but needs to be cleaned up and put into standalone branch.

lucasw · 2020-07-28T15:09:43Z

@xkortex I'm also trying to get failed required nodes to make ci jobs fail, and started experimenting with this in lucasw@0eb9ba4 . Use with caution- there were some odd cases where roslaunch lost track of child processes but I think I'm avoiding that now.

…process at least for a regular parent launch process, child and remote processes need looking at. May solve ros#919 but needs to be cleaned up and put into standalone branch.

betaboon · 2020-10-13T18:03:47Z

@lucasw any update on your branch? is there anything we can do to assist you in getting this finalized/tested? i got here due to the same reason: a simple smoketest in ci :)

… a regular parent launch process, child and remote processes need looking at. May solve ros#919

lucasw · 2020-10-19T17:47:05Z

@betaboon I put it into a PR #2082

… a regular parent launch process, child and remote processes need looking at. May solve ros#919

…process at least for a regular parent launch process, child and remote processes need looking at. May solve ros#919 but needs to be cleaned up and put into standalone branch.

… a regular parent launch process, child and remote processes need looking at. May solve ros#919

…process at least for a regular parent launch process, child and remote processes need looking at. May solve ros#919 but needs to be cleaned up and put into standalone branch.

Resolves ros#919

dirk-thomas added the enhancement label Jul 21, 2017

lucasw added a commit to lucasw/ros_comm that referenced this issue Oct 19, 2020

Return the exit code to the caller of a required process at least for…

92fad90

… a regular parent launch process, child and remote processes need looking at. May solve ros#919

lucasw mentioned this issue Oct 19, 2020

Return the exit code a required process through roslaunch #2082

Open

lucasw added a commit to lucasw/ros_comm that referenced this issue Oct 19, 2020

Return the exit code to the caller of a required process at least for…

b28da16

… a regular parent launch process, child and remote processes need looking at. May solve ros#919

lucasw added a commit to lucasw/ros_comm that referenced this issue Nov 6, 2020

Return the exit code to the caller of a required process at least for…

0acad1b

… a regular parent launch process, child and remote processes need looking at. May solve ros#919

lucasw added a commit to lucasw/ros_comm that referenced this issue Mar 21, 2021

Return the exit code to the caller of a required process at least for…

43e5388

… a regular parent launch process, child and remote processes need looking at. May solve ros#919

Bonifatius94 mentioned this issue Jan 14, 2022

Fix integration test ll7/paf21-1#51

Closed

rhaschke pushed a commit to ubi-agni/ros_comm that referenced this issue Aug 20, 2024

roslaunch: return exit code of a required process (2082)

2707b82

Resolves ros#919

rhaschke pushed a commit to ubi-agni/ros_comm that referenced this issue Aug 20, 2024

roslaunch: return exit code of a required process (ros#2082)

87850c8

Resolves ros#919

rhaschke pushed a commit to ros-o/ros_comm that referenced this issue Oct 15, 2024

roslaunch: return exit code of a required process (ros#2082)

27027a6

Resolves ros#919

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

roslaunch exit code 0 even if requried node died with non-zero exit code #919

roslaunch exit code 0 even if requried node died with non-zero exit code #919

sd1074 commented Oct 28, 2016 •

edited

Loading

TeeJayR commented Jan 3, 2017

alspitz commented Jul 19, 2018

xkortex commented Nov 22, 2019 •

edited

Loading

LukeAI commented May 11, 2020 •

edited

Loading

dirk-thomas commented May 13, 2020 •

edited

Loading

xkortex commented May 17, 2020

lucasw commented Jul 28, 2020

betaboon commented Oct 13, 2020

lucasw commented Oct 19, 2020

roslaunch exit code 0 even if requried node died with non-zero exit code #919

roslaunch exit code 0 even if requried node died with non-zero exit code #919

Comments

sd1074 commented Oct 28, 2016 • edited Loading

TeeJayR commented Jan 3, 2017

alspitz commented Jul 19, 2018

xkortex commented Nov 22, 2019 • edited Loading

LukeAI commented May 11, 2020 • edited Loading

dirk-thomas commented May 13, 2020 • edited Loading

xkortex commented May 17, 2020

lucasw commented Jul 28, 2020

betaboon commented Oct 13, 2020

lucasw commented Oct 19, 2020

sd1074 commented Oct 28, 2016 •

edited

Loading

xkortex commented Nov 22, 2019 •

edited

Loading

LukeAI commented May 11, 2020 •

edited

Loading

dirk-thomas commented May 13, 2020 •

edited

Loading