fix build if no gtest is installed #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`catkin_add_gtest` will not define a target if `gtest` is not installed, but not fail the compile. Unfortunately the `target_link_libraries` will then fail the build, i.e: ``` CMake Warning at /home/dreuter/ros/noetic/install_isolated/share/catkin/cmake/test/gtest.cmake:160 (message): skipping gtest 'resource_retriever_utest' in project 'resource_retriever' because gtest was not found Call Stack (most recent call first): /home/dreuter/ros/noetic/install_isolated/share/catkin/cmake/test/gtest.cmake:89 (_catkin_add_executable_with_google_test) /home/dreuter/ros/noetic/install_isolated/share/catkin/cmake/test/gtest.cmake:37 (_catkin_add_google_test) test/CMakeLists.txt:3 (catkin_add_gtest) CMake Error at test/CMakeLists.txt:4 (target_link_libraries): Cannot specify link libraries for target "resource_retriever_utest" which is not built by this project. ``` By checking if the target exists before calling `target_link_libraries`, we can restore the intended behavior of `catkin_add_gtest` to "silently" fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
catkin_add_gtestwill not define a target ifgtestis not installed,but not fail the compile.
Unfortunately the
target_link_librarieswill then fail the build, i.e:By checking if the target exists before calling
target_link_libraries,we can restore the intended behavior of
catkin_add_gtestto "silently"fail.