Represent the arity of uncurried function definitions directly in the… #7197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
force-pushed
the
uncurried-fun-decl-arity
branch
from
02459bf to
8ff4713
Compare
This goes towards making all arities explicit.
The arity is later overridden anyway, but being explicit can help cleaning up later on if `Function$` is removed entirely.
Cosmetic change that will be needed later to remove `Function$`.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.
| Benchmark suite | Current: dfb4b2e | Previous: e1b7fb7 | Ratio |
|---|---|---|---|
Print RedBlackTreeNoComments.res - time/run |
2.3617198066666667 ms |
2.10057036 ms |
1.12 |
This comment was automatically generated by workflow using github-action-benchmark.
cknitt
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… AST.
This only changes the representation of the arity, and only affects the untyped ast.
Later on, one can try to remove
Function$entirely, as an uncurried function definition will be simply one where the arty is present.