AST: store arity in function type #7195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cknitt in there a way to run CI on PRs like these, which are based on other PRs not yet merged? |
|
This is defined here: rescript/.github/workflows/ci.yml Line 12 in 606719f So I think it should work if you extend that by the name of the branch you want to make a PR against (in that branch). |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.
| Benchmark suite | Current: 655045e | Previous: e1b7fb7 | Ratio |
|---|---|---|---|
Print RedBlackTreeNoComments.res - time/run |
2.2179153266666667 ms |
2.10057036 ms |
1.06 |
This comment was automatically generated by workflow using github-action-benchmark.
cristianoc
commented
Dec 9, 2024
cristianoc
force-pushed
the
arity
branch
2 times, most recently
from
a12fc3c to
0c439eb
Compare
cristianoc
changed the title
This needs some info from function definition that is not readily available. Better to postpone this until arity is explicit in function definitions.
Fix uncurried function type handling in FFI and type system This commit improves handling of uncurried function types, particularly in FFI and the type system: - Add arity information to @obj externals by returning arity from process_obj - Fix filter_arrow to properly handle arity in type unification - Remove invalid assert false in ast_uncurried.ml - Update type_function and type_application to properly handle arity information - Pass arity through to is_ignore function for consistent type checking These changes help ensure proper type checking and arity handling for uncurried functions, especially in FFI bindings using @obj.
cknitt
reviewed
Dec 18, 2024
cknitt
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of storing arity in a second type parameter to builtin type
function$<_, _>, add an arity field to:1
Ptyp_arrow: to represent types with arity from the source program in the untyped AST (e.g.(t1, t2) => t3has arity 2.2
Ttyp_arrow: to represent types with arity from the source program in the typed AST.3
Tarrow: to represent the inferred/computed types. This required adapting the type inference and unification mechanisms.