-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Support for half-float mixed precise in brute-force #2382
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
0780518
[FEA] Support for half-float mixed precise in brute-force
rhdong 0e9e70b
Merge branch 'branch-24.08' into half_knn
rhdong 3dd5fdf
recover the test cases
rhdong eb3b8a6
try to fix sddmm error in conda-cpp-tests
rhdong 60ff874
check sparse
rhdong 6103fd1
fix the Floating-point exception
rhdong d744d59
Merge remote-tracking branch 'origin/branch-24.08' into half_knn
rhdong efec888
conditionally skip sddmm test cases
rhdong a55f100
conditionally skip sddmm test cases(2nd try)
rhdong 920997f
half2float -> to_float
rhdong f2f21c4
Merge branch 'branch-24.08' into half_knn
rhdong 43ee640
CI fix caused by half2float -> to_float
rhdong 11a9988
Merge branch 'branch-24.10' into half_knn
rhdong aa6da25
Merge branch 'branch-24.10' into half_knn
rhdong 3d8b7ca
update masked_matmul to support mixed precision
rhdong 34dbde8
fix CI fail by skipping low version cuSparse
rhdong 10e5204
fix: illegal instruction by `masked_matmul` on V100 with a dim not mu…
rhdong 4046bf8
Merge branch 'branch-24.10' into half_knn
rhdong 1ed4801
[Fix] bug of `masked_matmul` on non-2-power of `num_cols`
rhdong 4d55c57
[Fix] compilation error of `gemm` & `transpose` under cuml
rhdong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need half support for the
asin
function?I'm wondering if we should either remove the half support for this function, or add half support for all the other trigonometric functions in this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, maybe we can. As of now, it's a kind of trade-off. I understand your meaning; some distance algorithms need this as supporting half; removing it will cause a compilation error. If we bring half everything, that could be ideal, but the workload can be out of control..