Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in blockRankedReduce #2226

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Fix bug in blockRankedReduce #2226

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b7af427
fix ranked reduction bug
akifcorduk Mar 14, 2024
bcfa9cd
use lower and upper bounds for generality
akifcorduk Mar 15, 2024
ffdbbdc
Merge branch 'branch-24.04' into fix_reduce_bug
akifcorduk Mar 15, 2024
1558c0e
Merge branch 'branch-24.04' into fix_reduce_bug
tfeher Mar 18, 2024
942023d
Merge branch 'branch-24.04' into fix_reduce_bug
tfeher Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions cpp/include/raft/util/reduction.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,10 @@ DI std::pair<T, i_t> blockRankedReduce(T val,
val = values[lane];
idx = indices[lane];
} else {
// get the min if it is a max op, get the max if it is a min op
val = reduce_op(std::numeric_limits<T>::min(), std::numeric_limits<T>::max()) ==
std::numeric_limits<T>::min()
? std::numeric_limits<T>::max()
: std::numeric_limits<T>::min();
// get the lower_bound of the type if it is a max op,
// get the upper bound of the type if it is a min op
val = reduce_op(lower_bound<T>(), upper_bound<T>()) == lower_bound<T>() ? upper_bound<T>()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the identity should be known at compile time rather than evaluating a max/min operation to determine the identity for the given operation.

: lower_bound<T>();
idx = -1;
}
__syncthreads();
Expand Down
Loading