Fix bug in blockRankedReduce #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akifcorduk
added
bug
|
/ok to test |
1 similar comment
|
/ok to test |
bdice
requested changes
Mar 14, 2024
bdice
approved these changes
Mar 15, 2024
| : std::numeric_limits<T>::min(); | ||
| // get the lower_bound of the type if it is a max op, | ||
| // get the upper bound of the type if it is a min op | ||
| val = reduce_op(lower_bound<T>(), upper_bound<T>()) == lower_bound<T>() ? upper_bound<T>() |
There was a problem hiding this comment.
It seems like the identity should be known at compile time rather than evaluating a max/min operation to determine the identity for the given operation.
|
/ok to test |
tfeher
approved these changes
Mar 18, 2024
|
/ok to test |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug appearing for negative floating point numbers with a max reduce operation. The
std::numeric_limits<T>::min()is greater than the negative floating point values whereas we want it to be smaller than all representable values.This PR replaces the
minwith thelowest.