Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-static bounce buffer option #454

Merged
merged 10 commits into from
Sep 2, 2024
Merged

Non-static bounce buffer option #454

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7fdff4c
dynamic bounce buffer size
madsbk Sep 2, 2024
cc72163
AllocRetain: leak allocations at exit
madsbk Sep 2, 2024
902385a
AllocRetain: std::size_t clear()
madsbk Sep 2, 2024
c82c1d5
buffer.py
madsbk Sep 2, 2024
7039bef
test_bounce_buffer_clear
madsbk Sep 2, 2024
6c92595
doc
madsbk Sep 2, 2024
7597bae
Apply suggestions from code review
madsbk Sep 2, 2024
49bf4ac
test
madsbk Sep 2, 2024
669dfa2
bounce_buffer_free
madsbk Sep 2, 2024
6e60f9a
doc
madsbk Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc
  • Loading branch information
@madsbk
madsbk committed Sep 2, 2024
commit 6c92595b6e218dd74499c278b4794d6899ed7f03
6 changes: 3 additions & 3 deletions cpp/include/kvikio/bounce_buffer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ class AllocRetain {

AllocRetain() = default;

// Notice, we do not clear the allocations at destruction thus the allocations are
// leak at exit. We do this because `AllocRetain::instance()` stores the allocations
// in a static stack that are destructed below main, which is not allowed in CUDA:
// Notice, we do not clear the allocations at destruction thus the allocations leaks
// at exit. We do this because `AllocRetain::instance()` stores the allocations in a
// static stack that are destructed below main, which is not allowed in CUDA:
// <https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#initialization>
~AllocRetain() noexcept = default;

Expand Down