Non-static bounce buffer option #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsbk
added
improvement
wence-
requested changes
Sep 2, 2024
python/kvikio/tests/test_basic_io.py
Outdated
| with kvikio.defaults.set_bounce_buffer_size(2048): | ||
| with kvikio.CuFile(filename, "w") as f: | ||
| f.write(cupy.arange(10)) # populate the bounce buffer | ||
| assert kvikio.buffer.bounce_buffer_clear() == 2048 |
There was a problem hiding this comment.
question: Is this indentation right? I thought that the context manager on line 288 would reset the bounce buffer size to the default (16MiB) size, and so this clear would return 0 (because when we exited the block we had to clear the bounce buffers).
There was a problem hiding this comment.
The bounce buffer isn't cleared on context exit, added the following comment:
# Notice, since the bounce buffer size is only checked when the buffer
# is used, we populate the bounce buffer in between we clear it.
|
Does this also close #452? |
Co-authored-by: Lawrence Mitchell <[email protected]>
|
Thanks for the review @wence- |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #451
closes #452
Also some refactor/clean up