Add KvikIO devcontainers #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…command workaround
|
/ok to test |
|
/ok to test |
madsbk
added
improvement
|
It might be something with my system, but I am getting a |
|
@madsbk looks like a temporary network issue: Could you retry? |
The same error :/ I can access of the index files manually, |
|
Then maybe you have an issue with your docker bridge network. Can you build other containers that run |
…o fea/devcontainers
|
/ok to test |
Reinstalling docker fixed the issue, it works now thanks! |
|
/ok to test |
madsbk
approved these changes
Sep 8, 2023
|
/ok to test |
AyodeAwe
approved these changes
Sep 13, 2023
|
/merge |
|
Awesome, thanks @trxcllnt ! |
rapids-bot bot
pushed a commit
to rapidsai/cuspatial
that referenced
this pull request
Sep 25, 2023
Removes the unified and isolated devcontainers in favor of just the single one. The unified devcontainers are [still available](https://github.com/rapidsai/devcontainers/blob/d970ac17a894f5d1047fcfd17cffa6d14fe66ec8/.devcontainer/cuda12.0-conda/devcontainer.json#L23-L31) in the [`rapidsai/devcontainers`](https://github.com/rapidsai/devcontainers) repository. Adds an optional job to the `pr.yaml` to [build the cuGraph libs in each devcontainer](https://github.com/trxcllnt/cuspatial/blob/fea/devcontainers/.github/workflows/pr.yaml#L106-L111), so the build caches are populated for devs by CI. Other PRs: * rapidsai/rmm#1328 * rapidsai/kvikio#273 * rapidsai/cudf#14015 * rapidsai/raft#1791 * rapidsai/cumlprims_mg#149 * rapidsai/cuml#5568 * rapidsai/cugraph-ops#538 * rapidsai/cugraph#3838 Authors: - Paul Taylor (https://github.com/trxcllnt) - H. Thomson Comer (https://github.com/thomcom) Approvers: - Mark Harris (https://github.com/harrism) - Jake Awe (https://github.com/AyodeAwe) URL: #1263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some devcontainers to help simplify building the KvikIO C++ and Python libraries.
It also adds an optional job to the
pr.yamlto build the KvikIO libs in each devcontainer, so the build caches are populated for devs by CI.A devcontainer can be launched by clicking the "Reopen in Container" button that VSCode shows when opening the repo (or by using the "Rebuild and Reopen in Container" command from the command palette):
Clicking this button will cause VSCode to prompt the user to select one of these devcontainer variants:
On startup, the devcontainer creates or updates the conda/pip environment using
kvikio/dependencies.yaml. The envs/package caches are cached on the host via volume mounts, which are described in more detail in.devcontainer/README.md.The container includes convenience functions to clean, configure, and build the various KvikIO components:
cmake -S ~/kvikio/cpp -B ~/kvikio/cpp/buildandcmake --build ~/kvikio/cpp/buildpip install --editable ~/kvikio/cppUnlike
build.sh, these convenience scripts don't install the libraries after building them. Instead, they automatically inject the correct arguments to build the C++ libraries from source and use their build dirs as package roots:Checklist