-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cuGraph devcontainers #3838
Add cuGraph devcontainers #3838
Conversation
…command workaround
/ok to test |
/ok to test |
/ok to test |
1 similar comment
/ok to test |
/ok to test |
/ok to test |
/ok to test |
/ok to test |
Removes the unified and isolated devcontainers in favor of just the single one. The unified devcontainers are [still available](https://github.com/rapidsai/devcontainers/blob/d970ac17a894f5d1047fcfd17cffa6d14fe66ec8/.devcontainer/cuda12.0-conda/devcontainer.json#L23-L31) in the [`rapidsai/devcontainers`](https://github.com/rapidsai/devcontainers) repository. Adds an optional job to the `pr.yaml` to [build the cuGraph libs in each devcontainer](https://github.com/trxcllnt/cuspatial/blob/fea/devcontainers/.github/workflows/pr.yaml#L106-L111), so the build caches are populated for devs by CI. Other PRs: * rapidsai/rmm#1328 * rapidsai/kvikio#273 * rapidsai/cudf#14015 * rapidsai/raft#1791 * rapidsai/cumlprims_mg#149 * rapidsai/cuml#5568 * rapidsai/cugraph-ops#538 * rapidsai/cugraph#3838 Authors: - Paul Taylor (https://github.com/trxcllnt) - H. Thomson Comer (https://github.com/thomcom) Approvers: - Mark Harris (https://github.com/harrism) - Jake Awe (https://github.com/AyodeAwe) URL: #1263
/ok to test |
Hi @trxcllnt - I vaguely remember someone mentioning that these images could be built outside of VSCode and the corresponding containers can be used by non-VSCode users. Is that correct, and if so, are there instructions on how to do that? I still have not installed VSCode yet and did not see how to try these changes in my dev environment. |
@rlratzel yes, you can use the devcontainers CLI |
/ok to test |
/merge |
A couple PRs were merged after `branch-23.12` was created and contained RAPIDS versions that need to be updated in `branch-23.12`. Ref: - #3838 - #3852 Authors: - Ray Douglass (https://github.com/raydouglass) - Rick Ratzel (https://github.com/rlratzel) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Brad Rees (https://github.com/BradReesWork) URL: #3905
Description
This PR adds some devcontainers to help simplify building the cuGraph C++ and Python libraries.
It also adds an optional job to the
pr.yaml
to build the cuGraph libs in each devcontainer, so the build caches are populated for devs by CI.A devcontainer can be launched by clicking the "Reopen in Container" button that VSCode shows when opening the repo (or by using the "Rebuild and Reopen in Container" command from the command palette):
Clicking this button will cause VSCode to prompt the user to select one of these devcontainer variants:
On startup, the devcontainer creates or updates the conda/pip environment using
cugraph/dependencies.yaml
. The envs/package caches are cached on the host via volume mounts, which are described in more detail in.devcontainer/README.md
.The container includes convenience functions to clean, configure, and build the various cuGraph components:
cmake -S ~/cugraph/cpp -B ~/cugraph/cpp/build
andcmake --build ~/cugraph/cpp/build
pip install --editable ~/cugraph/cpp
Unlike
build.sh
, these convenience scripts don't install the libraries after building them. Instead, they automatically inject the correct arguments to build the C++ libraries from source and use their build dirs as package roots:Checklist