Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the batch API when in compatibility mode #239

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Jun 13, 2023

Fixes the CI error in #224.

Additionally, we now use the mangled name of the CUfileOpError to determine if cuFile's batch API is available (v12.0.1+). Previously, we used the mangled name of cuFileBatchContextState, which corresponds to v12.0.0+.

@madsbk madsbk added bug Something isn't working non-breaking Introduces a non-breaking change labels Jun 13, 2023
@madsbk madsbk marked this pull request as ready for review June 13, 2023 15:26
@madsbk madsbk mentioned this pull request Jun 13, 2023
3 tasks
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed the issue seen in #224.

@bdice
Copy link
Contributor

bdice commented Jun 13, 2023

I'm going to merge this to unblock #224.

@bdice
Copy link
Contributor

bdice commented Jun 13, 2023

/merge

@rapids-bot rapids-bot bot merged commit 202fae8 into rapidsai:branch-23.08 Jun 13, 2023
@jakirkham
Copy link
Member

Thanks all! 🙏

@madsbk madsbk deleted the batch_api_and_compat_mode branch June 14, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants