Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KvikIO: Build CUDA 12 packages #224

Merged
merged 55 commits into from
Jun 22, 2023
Merged

KvikIO: Build CUDA 12 packages #224

merged 55 commits into from
Jun 22, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented May 25, 2023 •
edited by jakirkham
Loading

Description

This PR builds libkvikio and kvikio conda packages using CUDA 12. Resolves #175

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Fixes #175

@bdice
Copy link
Contributor Author

bdice commented May 25, 2023 •
edited
Loading

I'm seeing failures here that appear to be unrelated to my changes. I can't compile branch-23.08 locally using the RAPIDS CI images. Testing locally with branch-23.06 also failed.

Details 

CMake Error at /opt/conda/conda-bld/_build_env/share/cmake-3.26/Modules/CMakeTestCXXCompiler.cmake:60 (message):
  The C++ compiler

    "/opt/conda/conda-bld/_build_env/bin/aarch64-conda-linux-gnu-c++"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: /opt/conda/conda-bld/work/cpp/build/CMakeFiles/CMakeScratch/TryCompile-HnL0zR
    
    Run Build Command(s):/opt/conda/conda-bld/_build_env/bin/ninja -v cmTC_969ad && [1/2] sccache /opt/conda/conda-bld/_build_env/bin/aarch64-conda-linux-gnu-c++   -fvisibility-inlines-hidden -fmessage-length=0 -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O3 -pipe -isystem /opt/conda/conda-bld/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/include -fdebug-prefix-map=/opt/conda/conda-bld/work=/usr/local/src/conda/libkvikio-split- -fdebug-prefix-map=/opt/conda/conda-bld/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho=/usr/local/src/conda-prefix -isystem /usr/local/cuda/include -o CMakeFiles/cmTC_969ad.dir/testCXXCompiler.cxx.o -c /opt/conda/conda-bld/work/cpp/build/CMakeFiles/CMakeScratch/TryCompile-HnL0zR/testCXXCompiler.cxx
    FAILED: CMakeFiles/cmTC_969ad.dir/testCXXCompiler.cxx.o 
    sccache /opt/conda/conda-bld/_build_env/bin/aarch64-conda-linux-gnu-c++   -fvisibility-inlines-hidden -fmessage-length=0 -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O3 -pipe -isystem /opt/conda/conda-bld/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/include -fdebug-prefix-map=/opt/conda/conda-bld/work=/usr/local/src/conda/libkvikio-split- -fdebug-prefix-map=/opt/conda/conda-bld/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho=/usr/local/src/conda-prefix -isystem /usr/local/cuda/include -o CMakeFiles/cmTC_969ad.dir/testCXXCompiler.cxx.o -c /opt/conda/conda-bld/work/cpp/build/CMakeFiles/CMakeScratch/TryCompile-HnL0zR/testCXXCompiler.cxx
    sccache: error: Timed out waiting for server startup. Maybe the remote service is unreachable?
    Run with SCCACHE_LOG=debug SCCACHE_NO_DAEMON=1 to get more information
    ninja: build stopped: subcommand failed.
    
    

  

  CMake will not be able to correctly generate this project.

@jakirkham
Copy link
Member

Thanks Bradley! 🙏

Adding a trivial change PR ( #225 ) to test CI

@jakirkham jakirkham added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels May 26, 2023
@bdice
Copy link
Contributor Author

bdice commented May 26, 2023

CI issues were fixed by #226.

@bdice
Copy link
Contributor Author

bdice commented May 26, 2023

@madsbk Can you add a "DO NOT MERGE" label to prevent merger?

@bdice
Copy link
Contributor Author

bdice commented May 26, 2023

CI is expected to fail for kvikio because cupy packages for CUDA 12 are not yet available. In the meantime, we can use the CI packages from libkvikio to unblock rapidsai/cudf#12922.

@jakirkham
Copy link
Member

Can you add a "DO NOT MERGE" label to prevent merger?

Created one and added it here. Label checker seems to pick it up ok

@bdice bdice mentioned this pull request Jun 12, 2023
Merged
4 tasks
@vyasr vyasr added feature request New feature or request and removed improvement Improves an existing functionality DO NOT MERGE labels Jun 21, 2023
@vyasr vyasr marked this pull request as ready for review June 21, 2023 20:27
@vyasr vyasr requested review from a team as code owners June 21, 2023 20:27
bdice
bdice commented Jun 21, 2023
View reviewed changes
Copy link
Contributor Author

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't request changes on my own PR -- but I have several questions for us to consider.

conda/recipes/kvikio/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/kvikio/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/kvikio/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/libkvikio/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/libkvikio/meta.yaml Show resolved Hide resolved
@bdice bdice requested review from jakirkham and vyasr June 22, 2023 06:18
@bdice bdice self-assigned this Jun 22, 2023
@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 84f8556 into rapidsai:branch-23.08 Jun 22, 2023
@jakirkham
Copy link
Member

Thanks all! 🙏

@pentschev pentschev mentioned this pull request Jun 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raydouglass raydouglass raydouglass approved these changes

@jakirkham jakirkham jakirkham approved these changes

@vyasr vyasr vyasr approved these changes

Assignees

@bdice bdice

Labels
feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KvikIO: CUDA 12 Conda Packages
5 participants
@bdice @jakirkham @madsbk @vyasr @raydouglass