-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sccache s3 controls #226
Merged
rapids-bot
merged 4 commits into
rapidsai:branch-23.06
from
robertmaynard:bug/add_sccache_s3_controls
May 26, 2023
Merged
Add sccache s3 controls #226
rapids-bot
merged 4 commits into
rapidsai:branch-23.06
from
robertmaynard:bug/add_sccache_s3_controls
May 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
force-pushed
the
bug/add_sccache_s3_controls
branch
from
May 26, 2023 13:01
1ce1935
to
c120583
Compare
bdice
approved these changes
May 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @robertmaynard. I thought I checked for this earlier but must have overlooked it! 😅
Co-authored-by: Bradley Dice <[email protected]>
/merge |
madsbk
approved these changes
May 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @robertmaynard !
This was referenced May 26, 2023
Closed
Thanks all! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix comiler timeouts that are occuring when we try to build anything since sccache isn't talking with s3 properly.
issue: