Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Python 3.12 support in install selector #539

Merged
merged 5 commits into from
Sep 18, 2024
Merged

add Python 3.12 support in install selector #539

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8c0d7f6
add Python 3.12 support in install selector
jameslamb Sep 10, 2024
e6c3aa4
fixes
jameslamb Sep 10, 2024
50fc7a2
Apply suggestions from code review
jameslamb Sep 17, 2024
5715c9e
defer to the install selector for range of supported Python versions
jameslamb Sep 17, 2024
83330be
Update install/install.md
jameslamb Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions _includes/selector.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,9 +379,9 @@
active_additional_packages: [],

// all possible values
python_vers: ["3.9", "3.10", "3.11"],
python_vers: ["3.9", "3.10", "3.11", "3.12"],
python_vers_stable: ["3.9", "3.10", "3.11"],
python_vers_nightly: ["3.10", "3.11"],
python_vers_nightly: ["3.10", "3.11", "3.12"],
conda_cuda_vers: ["11", "12"],
pip_cuda_vers: ["11.4 - 11.8", "12"],
docker_cuda_vers: ["11.8", "12.0", "12.5"],
Expand Down Expand Up @@ -664,8 +664,9 @@
getpipNotes() {
var notes = [];
var install_location_notes = "RAPIDS pip packages are hosted by NVIDIA<br>"
var version_string = this.getSupportedPythonVersions().map((v) => `<code>${v}</code>`).join(", ")
notes = [...notes, install_location_notes,
'pip installation supports Python <code>3.9</code>, <code>3.10</code>, and <code>3.11</code>.<br>'];
`pip installation supports the following Python versions: ${version_string}.<br>`];

return notes.map(note => this.note_prefix + " " + note);
},
Expand Down Expand Up @@ -695,6 +696,12 @@
return this.getpipCmdHtml();
return "Not implemented yet!";
},
getSupportedPythonVersions() {
if (this.active_release === "Stable") {
return this.python_vers_stable;
}
return this.python_vers_nightly;
},
disableUnsupportedRelease(release) {
var isDisabled = false;
if (this.active_img_loc === "NGC" && this.active_method === "Docker" && release === "Nightly") isDisabled = true;
Expand All @@ -706,12 +713,7 @@
return isDisabled;
},
disableUnsupportedPython(python_version) {
var isDisabled = false;
if (this.active_release === "Stable") {
isDisabled = !this.python_vers_stable.includes(python_version)
} else if (this.active_release === "Nightly") {
isDisabled = !this.python_vers_nightly.includes(python_version)
}
var isDisabled = !this.getSupportedPythonVersions().includes(python_version)
return isDisabled;
},
disableUnsupportedImgType(type) {
Expand Down Expand Up @@ -744,11 +746,10 @@

This handles that case, updating to the oldest Python version supported by the chosen release.
*/
if (this.active_release === "Stable" && !this.python_vers_stable.includes(this.active_python_ver)) {
this.active_python_ver = this.python_vers_stable[0];
} else if (this.active_release === "Nightly" && !this.python_vers_nightly.includes(this.active_python_ver)) {
this.active_python_ver = this.python_vers_nightly[0];
}
var supported_python_versions = this.getSupportedPythonVersions()
if (!supported_python_versions.includes(this.active_python_ver)) {
this.active_python_ver = supported_python_versions[supported_python_versions.length - 1];
}
},
imgTypeClickHandler(e, type) {
if (this.isDisabled(e.target)) return;
Expand Down
3 changes: 2 additions & 1 deletion install/install.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,9 @@ ERROR: Could not find a version that satisfies the requirement cudf-cu12 (from v
ERROR: No matching distribution found for cudf-cu12
```
Check the suggestions below for possible resolutions:

- The pip index has moved from the initial experimental release! Ensure the correct `--extra-index-url=https://pypi.nvidia.com`
- Only Python versions 3.10 and 3.11 are supported
- Ensure you're using a Python version that RAPIDS supports (compare the values in the [the install selector](#selector) to the Python version reported by `pip --version`).
- RAPIDS pip packages require a recent version of pip that [supports PEP600](https://peps.python.org/pep-0600/){: target="_blank"}. Some users may need to update pip: `pip install -U pip`

<br/>
Expand Down