Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Python 3.12 support in install selector #539

Merged
merged 5 commits into from
Sep 18, 2024
Merged

add Python 3.12 support in install selector #539

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8c0d7f6
add Python 3.12 support in install selector
jameslamb Sep 10, 2024
e6c3aa4
fixes
jameslamb Sep 10, 2024
50fc7a2
Apply suggestions from code review
jameslamb Sep 17, 2024
5715c9e
defer to the install selector for range of supported Python versions
jameslamb Sep 17, 2024
83330be
Update install/install.md
jameslamb Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixes
  • Loading branch information
@jameslamb
jameslamb committed Sep 10, 2024
commit e6c3aa4c6113a2173347f3066539746d205af058
7 changes: 4 additions & 3 deletions _includes/selector.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,8 +664,9 @@
getpipNotes() {
var notes = [];
var install_location_notes = "RAPIDS pip packages are hosted by NVIDIA<br>"
var version_string = this.getSupportedPythonVersions().map((v) => `<code>${v}</code>`).join(", ")
notes = [...notes, install_location_notes,
'pip installation supports Python <code>3.9</code>, <code>3.10</code>, and <code>3.11</code>.<br>'];
`pip installation supports the following Python versions: ${version_string}.<br>`];

return notes.map(note => this.note_prefix + " " + note);
},
Expand Down Expand Up @@ -712,7 +713,7 @@
return isDisabled;
},
disableUnsupportedPython(python_version) {
var isDisabled = getSupportedPythonVersions().includes(python_version)
var isDisabled = !this.getSupportedPythonVersions().includes(python_version)
return isDisabled;
},
disableUnsupportedImgType(type) {
Expand Down Expand Up @@ -746,7 +747,7 @@
This handles that case, updating to the oldest Python version supported by the chosen release.
*/
var supported_python_versions = this.getSupportedPythonVersions()
if (!supported_python_version.includes(this.active_python_ver)) {
if (!supported_python_versions.includes(this.active_python_ver)) {
this.active_python_ver = supported_python_versions[0];
}
},
Expand Down