Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix advices. #136

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Fix advices. #136

merged 1 commit into from
Nov 18, 2022

Conversation

okamsn
Copy link
Contributor

@okamsn okamsn commented Nov 18, 2022

  • Advise corfu--insert, not corfu-insert.
  • Move Corfu advice to before corfu--insert.
  • Move Vertico to before vertico-insert (only 1 "-") just to be safe.

Problem found in issue #135.

- Advise `corfu--insert`, not `corfu-insert`.
- Move Corfu advice to before `corfu--insert`.
- Move Vertico to before `vertico-insert` (only 1 "-") just to be safe.

Problem found in issue radian-software#135.
@okamsn
Copy link
Contributor Author

okamsn commented Nov 18, 2022

@ssl19, does this change fix the problem for you?

@ssl19
Copy link

ssl19 commented Nov 18, 2022

Yes.
I've tested vertico-prescient and corfu-prescient with this patch, both look okay. The results are added to prescient--history correctly.

BTW, thanks for the quick response!

@okamsn okamsn merged commit 680fefa into radian-software:main Nov 18, 2022
@okamsn okamsn deleted the fix-advice branch November 18, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants