Skip to content

Commit

Permalink
Fix advices. (#136)
Browse files Browse the repository at this point in the history
- Advise `corfu--insert`, not `corfu-insert`.
- Move Corfu advice to before `corfu--insert`.
- Move Vertico to before `vertico-insert` (only 1 "-") just to be safe.

Problem found in issue #135.

Co-authored-by: okamsn <[email protected]>
  • Loading branch information
okamsn and okamsn authored Nov 18, 2022
1 parent a000de7 commit 680fefa
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion corfu-prescient.el
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ This mode will:
;; While sorting might not be enabled in Corfu, it might
;; still be enabled in another UI, such as Selectrum or Vertico.
;; Therefore, we still want to remember candidates.
(advice-add 'corfu-insert :after #'corfu-prescient--remember))
(advice-add 'corfu--insert :before #'corfu-prescient--remember))

;; Turn off mode.

Expand Down
2 changes: 1 addition & 1 deletion vertico-prescient.el
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ This mode will:
;; While sorting might not be enabled in Vertico, it might
;; still be enabled in another UI, such as Company or Corfu.
;; Therefore, we still want to remember candidates.
(advice-add 'vertico-insert :after #'vertico-prescient--remember))
(advice-add 'vertico-insert :before #'vertico-prescient--remember))

;; Turn off mode.

Expand Down

0 comments on commit 680fefa

Please sign in to comment.