Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boolean Hamiltonian gate yields fewer gates #4386

Merged
merged 36 commits into from
Oct 12, 2021
Merged

Boolean Hamiltonian gate yields fewer gates #4386

merged 36 commits into from
Oct 12, 2021

Conversation

tonybruguier
Copy link
Contributor

This is a follow-up on #4309. The intent is to have the output of he gate unchanged by doing the same operation using fewer CNOTs.

@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Aug 6, 2021
@tonybruguier tonybruguier marked this pull request as ready for review August 6, 2021 04:01
@tonybruguier tonybruguier requested review from cduck, vtomole and a team as code owners August 6, 2021 04:01
@tonybruguier
Copy link
Contributor Author

This is code extracted from #3989 into the present stand-alone, smaller PR. There has already been some review there, but more comments are of course welcome.

@tonybruguier tonybruguier mentioned this pull request Aug 6, 2021
Closed
@CirqBot CirqBot added size: XL lines changed >1000 size: L 250< lines changed <1000 and removed size: XL lines changed >1000 labels Aug 12, 2021
@tonybruguier
Copy link
Contributor Author

@95-martin-orion
Would you be interested in taking this over from Balint?

@95-martin-orion
Copy link
Collaborator

@95-martin-orion
Would you be interested in taking this over from Balint?

Happy to take on review of this PR, but I'll be out for the next couple of weeks. If it's urgent, please find another reviewer.

@tonybruguier
Copy link
Contributor Author

Oh, it is not urgent, but I also want you to have a relaxing coming back from vacation.

Maybe @cduck could take a look? My main concerns are not letting garbage code in and not overloading reviewers.

@tonybruguier
Copy link
Contributor Author

Thanks. I am sorry for having forgotten the reference. The code must have been quite cryptic. I tried to address all the comments, but I left one unresolved. PTAL.

@tonybruguier tonybruguier mentioned this pull request Sep 25, 2021
Closed
@tonybruguier
Copy link
Contributor Author

Thanks. PTAL

@tonybruguier
Merge branch 'master' of github.com:quantumlib/Cirq into simplify_boo…
4244551 
…l_hamiltonian
@tonybruguier
Merge branch 'master' of github.com:quantumlib/Cirq into simplify_boo…
fce3b01 
…l_hamiltonian
@tonybruguier
Merge branch 'master' of github.com:quantumlib/Cirq into simplify_boo…
b62d031 
…l_hamiltonian
@tonybruguier
Merge branch 'master' of github.com:quantumlib/Cirq into simplify_boo…
83f79c4 
…l_hamiltonian
@tonybruguier
Add unit test
313e37e
@tonybruguier
Expand unit test
458018a
@tonybruguier
Fix unit test
0b3db3c
@tonybruguier
Add test that is failing but should pass
d098d18
@tonybruguier
Merge branch 'master' of github.com:quantumlib/Cirq into simplify_boo…
880235b 
…l_hamiltonian
@tonybruguier
More comprehensive tests
6651ea6
@tonybruguier
Merge branch 'master' of github.com:quantumlib/Cirq into simplify_boo…
18b55ec 
…l_hamiltonian
@tonybruguier
Merge branch 'master' of github.com:quantumlib/Cirq into simplify_boo…
9087b97 
…l_hamiltonian
@tonybruguier
Fix code and make unit tests pass
e82714a
@tonybruguier
Copy link
Contributor Author

Sorry for the delay. I hadn't forgotten, I was just needing a little time to understand things. @95-martin-orion PTAL when you can.

95-martin-orion
95-martin-orion approved these changes Oct 11, 2021
View reviewed changes
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor cleanups left, but otherwise I think this is ready. Thanks for bearing with me!

cirq-core/cirq/ops/boolean_hamiltonian.py Outdated Show resolved Hide resolved
cirq-core/cirq/ops/boolean_hamiltonian_test.py Outdated Show resolved Hide resolved
cirq-core/cirq/ops/boolean_hamiltonian_test.py Show resolved Hide resolved
@tonybruguier
Copy link
Contributor Author

@95-martin-orion PTAL when you have the time

@95-martin-orion 95-martin-orion merged commit bd2e63c into quantumlib:master Oct 12, 2021
@tonybruguier tonybruguier deleted the simplify_bool_hamiltonian branch October 12, 2021 14:28
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@tonybruguier @rht
Boolean Hamiltonian gate yields fewer gates (quantumlib#4386)
129aa86 
* Boolean Hamiltonian gate yields fewer gates

* Address some of the comments

* Address some of the comments

* Add unit test

* Expand unit test

* Fix unit test

* Add test that is failing but should pass

* More comprehensive tests

* Fix code and make unit tests pass

* Address comments
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@tonybruguier
Boolean Hamiltonian gate yields fewer gates (quantumlib#4386)
e346f96 
* Boolean Hamiltonian gate yields fewer gates

* Address some of the comments

* Address some of the comments

* Add unit test

* Expand unit test

* Fix unit test

* Add test that is failing but should pass

* More comprehensive tests

* Fix code and make unit tests pass

* Address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@95-martin-orion 95-martin-orion 95-martin-orion approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

@tanujkhattar tanujkhattar Awaiting requested review from tanujkhattar

Assignees

@95-martin-orion 95-martin-orion

Labels
cla: yes Makes googlebot stop complaining. size: L 250< lines changed <1000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonybruguier @95-martin-orion @CirqBot