Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean Hamiltonian gate #4309

Merged
merged 49 commits into from
Aug 6, 2021
Merged

Conversation

tonybruguier
Copy link
Contributor

Following #4282, the present PR would like to add a gate that allows computing the Hamiltonian from a Boolean expression. Note that while the decomposition is somewhat efficient, more optimizations are possible and planned in a follow-up PR.

tonybruguier and others added 27 commits July 2, 2021 20:58
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Jul 9, 2021
@tonybruguier tonybruguier marked this pull request as ready for review July 9, 2021 21:56
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, just found a couple of nits, please add those.

cirq-core/cirq/ops/boolean_hamiltonian.py Outdated Show resolved Hide resolved
cirq-core/cirq/ops/boolean_hamiltonian.py Outdated Show resolved Hide resolved
cirq-core/cirq/ops/boolean_hamiltonian.py Outdated Show resolved Hide resolved
@tonybruguier
Copy link
Contributor Author

Thanks @balopat !
All the suggestions made sense, so I accepted them, merged the main branch, and re-ran the tests.
PTAL.

@balopat balopat added automerge Tells CirqBot to sync and merge this PR. (If it's running.) and removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) labels Aug 5, 2021
@MichaelBroughton MichaelBroughton added automerge Tells CirqBot to sync and merge this PR. (If it's running.) and removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) labels Aug 5, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Aug 6, 2021
@CirqBot CirqBot merged commit e56e15d into quantumlib:master Aug 6, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Aug 6, 2021
@tonybruguier tonybruguier deleted the simple_gate branch August 6, 2021 02:55
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Following quantumlib#4282, the present PR would like to add a gate that allows computing the Hamiltonian from a Boolean expression. Note that while the decomposition is somewhat efficient, more optimizations are possible and planned in a follow-up PR.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Following quantumlib#4282, the present PR would like to add a gate that allows computing the Hamiltonian from a Boolean expression. Note that while the decomposition is somewhat efficient, more optimizations are possible and planned in a follow-up PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants