Skip to content

gh-134584: Remove custom float decref ops #142576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 10 commits into from
Dec 15, 2025
Merged

gh-134584: Remove custom float decref ops #142576

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ed4381c
Convert old decref elimination cold for floats
Fidget-Spinner Dec 11, 2025
e689291
Fix tests and check
Fidget-Spinner Dec 11, 2025
207dc05
Merge remote-tracking branch 'upstream/main' into decref_float_refactor
Fidget-Spinner Dec 11, 2025
00f7818
address review comment
Fidget-Spinner Dec 11, 2025
9b7b864
simplify check
Fidget-Spinner Dec 11, 2025
1b3b922
address Mark's review
Fidget-Spinner Dec 13, 2025
8c0507f
fix assert
Fidget-Spinner Dec 13, 2025
d89a1d0
Merge remote-tracking branch 'upstream/main' into decref_float_refactor
Fidget-Spinner Dec 15, 2025
b67c6a7
Merge remote-tracking branch 'upstream/main' into decref_float_refactor
Fidget-Spinner Dec 15, 2025
1b443e2
upstream merge updates
Fidget-Spinner Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address review comment
  • Loading branch information
@Fidget-Spinner
Fidget-Spinner committed Dec 11, 2025
commit 00f78182a84d9205b5371aabc6d954448a417371
4 changes: 2 additions & 2 deletions Python/optimizer_analysis.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ incorrect_keys(PyObject *obj, uint32_t version)


#define STACK_LEVEL() ((int)(stack_pointer - ctx->frame->stack))
#define STACK_SIZE() ((int)(ctx->frame->stack_len) + MAX_CACHED_REGISTER)
#define STACK_SIZE() ((int)(ctx->frame->stack_len))

#define CURRENT_FRAME_IS_INIT_SHIM() (ctx->frame->code == ((PyCodeObject *)&_Py_InitCleanup))

Expand Down Expand Up @@ -196,7 +196,7 @@ check_stack_bounds(JitOptContext *ctx, JitOptRef *stack_pointer, int offset, int
(opcode == _RETURN_VALUE) ||
(opcode == _RETURN_GENERATOR) ||
(opcode == _YIELD_VALUE);
if (should_check && (stack_level < 0 || stack_level > STACK_SIZE())) {
if (should_check && (stack_level < 0 || stack_level > STACK_SIZE() + MAX_CACHED_REGISTER)) {
ctx->contradiction = true;
ctx->done = true;
return 1;
Expand Down
Loading