gh-134584: Remove custom float decref ops #142576
Open
+1,259
−1,782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
markshannon
reviewed
Dec 11, 2025
Member
markshannon
left a comment
markshannon
left a comment
There was a problem hiding this comment.
Can you leave the STACK_SIZE macro unchanged to avoid confusion and change https://github.com/python/cpython/pull/142576/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2L199
instead.
markshannon
reviewed
Dec 11, 2025
| ((PyFloatObject *)left_o)->ob_fval * | ||
| ((PyFloatObject *)right_o)->ob_fval; | ||
| res = PyStackRef_FromPyObjectSteal(PyFloat_FromDouble(dres)); | ||
| l = left; |
Member
There was a problem hiding this comment.
We shouldn't be setting the outputs before ERROR_IF.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.