Adding support for Box shapes to dyviz js #484
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python code
pydy.viz.shapes.py
provides support forBox
shapes but the type was not supported by the javascript code. This pull request add support for this, including the possibility to edit the parameters in the GUI when selectingEdit Objects
.I can try to add documentation and unittests but I will wait for your opinion.
Below is a sample code to test the feature (it might need a "Shift-F5" to reload the javascript from the browser's cache):
New Feature
commit message.
nosetests
) and on Travis CI.format.)
docs
directory)
pylint, to check your code)
Notes.
follow deprecation cycles.)