Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduces a new Jupyter Notebook Display Method For Basic PyThreeJS Animations #416

Merged
merged 55 commits into from
Dec 20, 2019
Merged

Introduces a new Jupyter Notebook Display Method For Basic PyThreeJS Animations #416

merged 55 commits into from
Dec 20, 2019

Conversation

moorepants
Copy link
Member

@moorepants moorepants commented Nov 29, 2019 •
edited
Loading

Based on PR the #297 but uses the newer KeyframeTrack objects in Three.js.

New Feature

  • There are no merge conflicts.
  • If there is a related issue, a reference to that issue is in the
    commit message.
  • Unit tests have been added for the new feature.
  • The PR passes tests both locally (run nosetests) and on Travis CI.
  • All public methods and classes have docstrings. (We use the numpydoc
    format    .)
  • An explanation has been added to the online documentation. (docs
    directory)
  • The code follows PEP8 guidelines. (use a linter, e.g.
    pylint, to check your code)
  • The new feature is documented in the Release
    Notes    .
  • The code is backwards compatible. (All public methods/classes must
    follow deprecation cycles.)
  • All reviewer comments have been addressed.

oliverlee and others added 30 commits October 22, 2015 03:35
@oliverlee
Add functions to generate scene widgets
9acac20
@oliverlee
Add method to display pythreejs scene
9eccab2
@oliverlee
Add scene time slider and animation thread
22e6d16
@oliverlee
WIP Set object transforms during animation
abaa8d0 
Transforms are not applied correctly, or need to be modified when using
pythreejs geometries.
@oliverlee
Add resimulate in pythreejs scene
a7b7c07
@oliverlee
Use pythreejs scene in mass spring damper example
cbcf7fa
@oliverlee
Add pydyviz notebook extension
6c2b214 
Bind Mesh objects to the time slider value with a TrajectoryLink, which
contains the object's position and quaternion trajectories.
@oliverlee
Compute resimulated time array with linspace
bf23080
@oliverlee
Move time loop into client side
adb6e1c
@oliverlee
Fix speedup and improve animation
3847eb5 
Use requestAnimationFrame instead of getInterval for more efficient
animation.
@oliverlee
Fix resimulation callback
0a29fe9
@oliverlee
Change default circle visualization and fix example
750f7b4 
Change default number of segments in a Circle geometry to 32. Rotate the
ceiling plate about the y-axis by pi/2 in the mass spring damper example
so that the plate axis is parallel to the motion of the mass.
@moorepants
Hello world nbextension working.
1381ebe
@moorepants
Some fixes to get the pythreejs viz working with latest versions of d…
95f1f29 
…ependencies.
@moorepants
Crude implementation of a simple pythreejs viewer based on the keyfra…
50ee75b 
…me tracks.
@moorepants
Added duration to the animation clip.
b6d2417
@moorepants
Removed uneeded method call.
273fb74
@moorepants
Added call to generate the transformation matrices.
6fb60fb
@moorepants
Renderer is working (might have to reload web page.
71c833b
@moorepants
The animation works.
2743ae8
@moorepants
Moved mesh generation into the Shape base class.
6909c52
@moorepants
Removed print statements and switched axes to AxesHelper.
beaff45
@moorepants
Added multiple directional lights.
4c8b1a9
@moorepants
Back to a single directional light.
092679b
@moorepants
Try to add DoubleSide back to the plane.
400c073
@moorepants
Fix doubleside issue for plane.
49ca135
@moorepants
Fixed merge conflict.
3d55aaf
@moorepants
Removed print statements.
c07d401
@moorepants
Added a box shape.
1ebbc93
@moorepants
Added an error if users don't change the name of the shape.
07f29d6
moorepants
moorepants commented Nov 29, 2019
View reviewed changes
moorepants
moorepants commented Nov 29, 2019
View reviewed changes
moorepants
moorepants commented Dec 19, 2019
View reviewed changes
@moorepants moorepants changed the title [WIP] Introduces a new Jupyter Notebook Display Method For Basic PyThreeJS Animations Introduces a new Jupyter Notebook Display Method For Basic PyThreeJS Animations Dec 19, 2019
@moorepants moorepants merged commit 9d692ec into pydy:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moorepants @oliverlee