updated circle funtion #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed function to relate thickness of drawn cylinder to radius object such that thickness will always be 1/50 of circle diameter, 1/25 of radius. such that the thickness and fact that it is a cylinder is not readily apparent to the casual user.
| @@ -246,7 +246,7 @@ DynamicsVisualizer.Scene = Object.extend(DynamicsVisualizer, { | |||
| case "Circle": | |||
| var geometry = new THREE.CylinderGeometry(object.radius, | |||
| object.radius, | |||
| 0.5,100); | |||
| object.radius/25,100); | |||
There was a problem hiding this comment.
this is the line you could enter zero or a higher divisor if you want a thinner disc shape.
|
here is a pic of the result, this can be changed to be thinner if we want if we choose to always use zero the two sides have different colors blue and black in my case.
|
decided after discussion to use the zero as the default value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed function to relate thickness of drawn cylinder to radius object such that thickness will always be 1/50 of circle diameter, 1/25 of radius. such that the thickness and fact that it is a cylinder is not readily apparent to the casual user.