Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added text boxes to edit the initial conditions in the GUI. #333

Merged
merged 6 commits into from
Mar 9, 2016
Merged

Added text boxes to edit the initial conditions in the GUI. #333

merged 6 commits into from
Mar 9, 2016

Conversation

moorepants
Copy link
Member

Partially fixes #206.

  • There are no merge conflicts.
  • If there is a related issue, a reference to that issue is in the
    commit message.
  • Unit tests have been added for the new feature.
  • The PR passes tests both locally (run nosetests) and on Travis CI.
  • All public methods and classes have docstrings. (We use the numpydoc
    format    .)
  • An explanation has been added to the online documentation. (docs
    directory)
  • The code follows PEP8 guidelines. (use a linter, e.g.
    pylint, to check your code)
  • The new feature is documented in the Release
    Notes    .
  • The code is backwards compatible. (All public methods/classes must
    follow deprecation cycles.)
  • All reviewer comments have been addressed.

@moorepants
Copy link
Member Author

selection_050

@pydy/pydy-developers Review needed.

@oliverlee
Copy link
Contributor

Can you add a short description of new feature to the release notes?

@moorepants
Copy link
Member Author

Note is added. I don't think we need to update the online docs yet. There will be some more gui changes.

@mvnnn
Copy link

mvnnn commented Mar 7, 2016

Need to space between two column.
screenshot from 2016-03-08 02 08 57

@moorepants
Copy link
Member Author

It looks like you are using chrome on linux. Can you report your browser and version?

The screenshot I have above works for Firefox 44 on ubuntu.

Thanks for trying this out.

@mvnnn
Copy link

mvnnn commented Mar 8, 2016

you are right. my browser is chrome and OS is Linux mint.

@oliverlee
Copy link
Contributor

Same issue with me.
OSX 10.11.3 and Chrome 49.0.2623.75 (64-bit).

@oliverlee
Copy link
Contributor

You should also change the initial condition labels so they aren't displayed as functions of time.

@moorepants
Copy link
Member Author

I've reported the overlap issue upstream: jupyter-widgets/ipywidgets#412. Let's see what they have to say.

@moorepants
Copy link
Member Author

I've improved the display of the input boxes. My solution is hacky but it seems to work ok.

Firefox 44, Ubuntu 15.10:

selection_054

@moorepants
Copy link
Member Author

Chromium has some odd vertical lines beside the mathjax.

selection_055

@oliverlee
Copy link
Contributor

Looks okay in Chrome for OSX:
screen shot 2016-03-09 at 16 54 08

@moorepants
Copy link
Member Author

Ok. I'm happy with this if you all are. I don't plan to add any more changes unless you all request. Please review and merge at will.

@oliverlee
Copy link
Contributor

+1 Merge when CI is complete.

moorepants added a commit that referenced this pull request Mar 9, 2016
@moorepants
Merge pull request #333 from moorepants/initial-conditions
53089b9 
Added text boxes to edit the initial conditions in the GUI.
@moorepants moorepants merged commit 53089b9 into pydy:master Mar 9, 2016
@moorepants moorepants deleted the initial-conditions branch May 30, 2017 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
visualization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The GUI rerun should support changing the initial conditions and time array.
3 participants
@moorepants @oliverlee @mvnnn