Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The width of the simulation canvas is now bounded by the Jupyter notebook borders. #332

Merged
merged 1 commit into from
Mar 6, 2016
Merged

The width of the simulation canvas is now bounded by the Jupyter notebook borders. #332

merged 1 commit into from
Mar 6, 2016

Conversation

moorepants
Copy link
Member

  • There are no merge conflicts.
  • If there is a related issue, a reference to that issue is in the
    commit message.
  • Unit tests have been added for the bug. (Please reference the issue #
    in the unit test.)
  • The tests pass both locally (run nosetests) and on Travis CI.
  • The code follows PEP8 guidelines. (use a linter, e.g.
    pylint, to check your code)
  • The bug fix is documented in the Release
    Notes    .
  • The code is backwards compatible. (All public methods/classes must
    follow deprecation cycles.)
  • All reviewer comments have been addressed.

Fixes #236.

I checked this in IPython 3 and 4 and get the same result:

selection_049

@moorepants
Copy link
Member Author

@pydy/pydy-developers This needs a review.

@tarzzz
Copy link
Contributor

tarzzz commented Mar 6, 2016

👍 You are on fire today, @moorepants :)

@moorepants
Copy link
Member Author

Thanks Tarun. Please check off the relevant items in the check list and let me know if this i ready to merge.

@moorepants
Copy link
Member Author

Ok, thanks. I'll add the note to the release notes after merging.

moorepants added a commit that referenced this pull request Mar 6, 2016
@moorepants
Merge pull request #332 from pydy/ipython-width
a5b88aa 
The width of the simulation canvas is now bounded by the Jupyter notebook borders.
@moorepants moorepants merged commit a5b88aa into master Mar 6, 2016
@moorepants moorepants deleted the ipython-width branch May 30, 2017 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
visualization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The visualization canvas is not bounded by the notebook width on large resolution screens.
2 participants
@moorepants @tarzzz