Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sympy.phyics.mechanics deprecated methods #309

Merged
merged 4 commits into from
Dec 27, 2015

Conversation

moorepants
Copy link
Member

Building on #298.

@moorepants
Copy link
Member Author

@oliverlee I don't think we can merge this as is. camera.py and light.py probably don't have good unit tests and when these are run with SymPy 0.7.4.1, which doesn't have these new attributes, the code will fail.

@moorepants
Copy link
Member Author

Actually maybe it does work because of this line in pre-0.7.7: https://github.com/sympy/sympy/blob/sympy-0.7.6.1/sympy/physics/mechanics/particle.py#L61

@moorepants
Copy link
Member Author

This is good to merge once the tests pass.

moorepants added a commit that referenced this pull request Dec 27, 2015
Replace sympy.phyics.mechanics deprecated methods
@moorepants moorepants merged commit 7b53eca into pydy:master Dec 27, 2015
@moorepants moorepants deleted the dep-warnings branch January 6, 2016 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants