Fix codegen line break #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverlee
force-pushed
the
fix-codegen-line-break
branch
from
a5e6f8a to
e201105
Compare
|
This looks good to me. |
oliverlee
force-pushed
the
fix-codegen-line-break
branch
3 times, most recently
from
73e8bae to
bfac43e
Compare
|
I've removed the commit that's included in #291. Feel free to merge after you've taken a look, assuming there are no other problems. |
|
Looks good. After the #291 merge and travis tests pass, then this is good to go in. Thanks for the fix! |
Some generated expressions, particularly those that contain only '*' and '/' operands, have no whitespace. In this case, the textwrap module may break the line in the middle of a symbol or mathematical expression if the line is long, resulting in code that cannot compile. This commit adds whitespace before and after the '*', '/' operands so that textwrap will have more options for inserting line breaks. The textwrap option 'break_long_words' is also set to True, allowing long lines in the event that no whitespace is present. This commit resolves pydy#263.
oliverlee
force-pushed
the
fix-codegen-line-break
branch
from
bfac43e to
e11f2fe
Compare
oliverlee
added a commit
that referenced
this pull request
Oct 21, 2015
Fix codegen line break. This resolves #263.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some generated expressions, particularly those that contain only '' and
'/' operands, have no whitespace. In this case, the textwrap module may
break the line in the middle of a symbol or mathematical expression if
the line is long, resulting in code that cannot compile. This commit
adds whitespace before and after the '', '/' operands so that textwrap
will have more options for inserting line breaks. The textwrap option
'break_long_words' is also set to True, allowing long lines in the event
that no whitespace is present.
A test has been added that reproduces the bug.
This pull request resolves #263.
This pull request depends on #291. Please merge that request first.