Fix scene simulation time #272

oliverlee · 2015-10-15T17:03:37Z

The time shows up as 0 when the model is loaded (not the first value in the times array). Maybe one of you knows how to fix it since I don't know JS.

We should probably implement some sort of speedup slider to change fps in the future.

tarzzz · 2015-10-15T17:13:31Z

Its been some time, but as I recall, there was no provision of providing the time vector to javascript. It took only (start_time, end_time and time_delta) and calculated time vector based on these. We will require some changes in code to accomodate both.

oliverlee · 2015-10-15T17:35:38Z

The start time is displayed correctly after the first time the simulation is run. If looped, the start time is correct if non zero.

It is only in the beginning, before the simulation has been run the first time, where the time is (possibly) incorrectly displayed as 0.

oliverlee · 2015-10-16T16:59:31Z

@tarzzz The time value is hardcoded to zero here:

pydy/pydy/viz/static/index.html

Line 91 in eaf45c6

Is there a way to set the initial time immediately after loading the model?

oliverlee · 2015-10-16T17:14:44Z

Also, when I modify .js files in the static directory, changes are not reflected when I start a server (or at least it doesn't show the changes when I 'inspect element' in my browser). Is there a way to force this to refresh?

tarzzz · 2015-10-16T17:44:26Z

We will need to set the initial time, dynamically on load.
Regarding the js files, after you change the code in static directory, you need to re-execute the python code for simulation.

Another way is to go to pydy-resources directory which is created for that simulation. You can edit code inside the js/ directory, test it there and if it works, change the same code in static directory, and push to github.

oliverlee · 2015-10-16T18:54:31Z

I've deleted the whole pydy resources directory and re-executed all the
python code but there's no change. This is the script I use:
https://github.com/oliverlee/bicycle/blob/master/python/scripts/create_viz.py

I'll try modifying the generated js directory later.
On Oct 16, 2015 19:44, "Tarun Gaba" [email protected] wrote:

We will need to set the initial time, dynamically on load.
Regarding the js files, after you change the code in static directory, you
need to re-execute the python code for simulation.

Another way is to go to pydy-resources directory which is created for that
simulation. You can edit code inside the js/ directory, test it there and
if it works, change the same code in static directory, and push to github.

—
Reply to this email directly or view it on GitHub
#272 (comment).

moorepants · 2015-10-17T02:04:05Z

Maybe we need to create a jupyter extension so that the js files for the viz are served from the user's notebook extension directory in their home directory. That could possibly avoid the copying of the files to the working directory.

oliverlee · 2015-10-17T13:13:56Z

This now works for me.

tarzzz · 2015-10-17T14:01:28Z

pydy/viz/scene.py

+            self._scene_info["timeDelta"] = total_time / (num_time_steps - 1)
+            self._scene_info["startTime"] = self.times[0]
+        else:
+            self._scene_info["timeDelta"] = 1.0 / self.frames_per_second


@oliverlee You should include the "startTime" dict key here also (can be set to zero). Else the scene_desc json files will become in-consistent for two cases, and js code will break. Then it should be okay to be merged in.
Thanks for the fix :)

This is ready to be merged.
On Oct 17, 2015 16:01, "Tarun Gaba" [email protected] wrote:

In pydy/viz/scene.py
#272 (comment):

@@ -408,9 +408,17 @@ def _generate_json(self, directory=None, prefix=None):
self._generate_scene_dict()

self._scene_info["simulationData"] = self._simulation_json_file

# NOTE : Python 3 division is imported at the top of the file so

# this will be a float.

self._scene_info["timeDelta"] = 1 / self.frames_per_second

if self.times is not None:

# Assume that times is evenly spaced and monotonic.

# TODO: Interpolate if times are not evenly spaced.

total_time = self.times[-1] - self.times[0]

self._scene_info["timeDelta"] = total_time / (num_time_steps - 1)

self._scene_info["startTime"] = self.times[0]

else:

self._scene_info["timeDelta"] = 1.0 / self.frames_per_second

@oliverlee https://github.com/oliverlee You should include the
"startTime" dict key here also (can be set to zero). Else the scene_desc
json files will become in-consistent for two cases, and js code will break.
Then it should be okay to be merged in.

—
Reply to this email directly or view it on GitHub
https://github.com/pydy/pydy/pull/272/files#r42309534.

moorepants · 2015-10-17T19:53:43Z

Update with master please.

moorepants · 2015-10-17T20:10:56Z

I just tried this branch with the mass_spring_damper notebook and changes the sys.times var to go from 5.0 to 10.0 seconds with 100 steps in time, but the slider bar gives me 0.0 to 3.3 seconds with 100 steps. The value to the left reflects the seconds and the value in the black box that follows the slider when dragged seems to reflect the frame number. So it doesn't seem to work for me.

tarzzz · 2015-10-18T07:23:03Z

We should come up with a standardized test for checking js related fixes. Fixing one thing might lead to something else breaking, and it is difficult to track unless someone manually runs the simulation and tests it.

moorepants · 2015-10-18T22:00:44Z

Ok, this now works for me. +1.

You need to update with master it seems.

Use simulation times when computing 'timeDelta'. Add 'startTime' and 'speedup' fields for future use in javascript scene.

Set scene time value to first value in scene.times array. This commit resolves issue pydy#253.

Fix scene simulation time

tarzzz self-assigned this Oct 16, 2015

oliverlee force-pushed the fix-scene-simulation-time branch from c9e998d to 1ac3f42 Compare October 17, 2015 13:13

tarzzz reviewed Oct 17, 2015
View reviewed changes

oliverlee force-pushed the fix-scene-simulation-time branch from 1ac3f42 to ffa15ef Compare October 17, 2015 14:11

oliverlee force-pushed the fix-scene-simulation-time branch from ffa15ef to cc3caca Compare October 17, 2015 20:01

oliverlee force-pushed the fix-scene-simulation-time branch from daa1e39 to 1f548f6 Compare October 17, 2015 23:00

oliverlee force-pushed the fix-scene-simulation-time branch from 1f548f6 to 7a2efe7 Compare October 18, 2015 09:50

oliverlee added 4 commits October 19, 2015 00:52

Fix slider time values

81eafb1

Use simulation times when computing 'timeDelta'. Add 'startTime' and 'speedup' fields for future use in javascript scene.

Display correct simulation time in scene

7d6cad5

Set initial time on scene load

30a4118

Set scene time value to first value in scene.times array. This commit resolves issue pydy#253.

Fix scene time when using System time array

62dbeaf

oliverlee force-pushed the fix-scene-simulation-time branch from 7a2efe7 to 62dbeaf Compare October 18, 2015 22:52

oliverlee added a commit that referenced this pull request Oct 19, 2015

Merge pull request #272 from oliverlee/fix-scene-simulation-time

b5edaf4

Fix scene simulation time

oliverlee merged commit b5edaf4 into pydy:master Oct 19, 2015

oliverlee deleted the fix-scene-simulation-time branch October 21, 2015 22:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix scene simulation time #272

Fix scene simulation time #272

oliverlee commented Oct 15, 2015

tarzzz commented Oct 15, 2015

oliverlee commented Oct 15, 2015

oliverlee commented Oct 16, 2015

oliverlee commented Oct 16, 2015

tarzzz commented Oct 16, 2015

oliverlee commented Oct 16, 2015

moorepants commented Oct 17, 2015

oliverlee commented Oct 17, 2015

tarzzz Oct 17, 2015

oliverlee Oct 17, 2015

oliverlee Oct 17, 2015

moorepants commented Oct 17, 2015

moorepants commented Oct 17, 2015

tarzzz commented Oct 18, 2015

moorepants commented Oct 18, 2015

Fix scene simulation time #272

Fix scene simulation time #272

Conversation

oliverlee commented Oct 15, 2015

tarzzz commented Oct 15, 2015

oliverlee commented Oct 15, 2015

oliverlee commented Oct 16, 2015

oliverlee commented Oct 16, 2015

tarzzz commented Oct 16, 2015

oliverlee commented Oct 16, 2015

moorepants commented Oct 17, 2015

oliverlee commented Oct 17, 2015

tarzzz Oct 17, 2015

Choose a reason for hiding this comment

oliverlee Oct 17, 2015

Choose a reason for hiding this comment

oliverlee Oct 17, 2015

Choose a reason for hiding this comment

moorepants commented Oct 17, 2015

moorepants commented Oct 17, 2015

tarzzz commented Oct 18, 2015

moorepants commented Oct 18, 2015