Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the general deprecation warning from System. #262

Merged
merged 1 commit into from
Aug 26, 2015

Conversation

moorepants
Copy link
Member

This was a bad idea. We shouldn't use a deprecation warning unless we are
actually deprecating something in a very specific way.

  • There are no merge conflicts.
  • If there is a related issue, a reference to that issue is in the
    commit message.
  • Unit tests have been added for the bug. (Please reference the issue #
    in the unit test.)
  • The tests pass both locally (run nosetests) and on Travis CI.
  • The code follows PEP8 guidelines. (use a linter, e.g.
    pylint, to check your code)
  • The bug fix is documented in the Release
    Notes
    .
  • The code is backwards compatible. (All public methods/classes must
    follow deprecation cycles.)
  • All reviewer comments have been addressed.

This was a bad idea. We shouldn't use a deprecation warning unless we are
acutally deprecating something in a very specific way.
@moorepants
Copy link
Member Author

@pydy/pydy-developers Can someone review and merge this? Thanks.

oliverlee added a commit that referenced this pull request Aug 26, 2015
Removed the general deprecation warning from System.
@oliverlee oliverlee merged commit df1e7fe into pydy:master Aug 26, 2015
@moorepants moorepants deleted the remove-dumb-warning branch September 15, 2015 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants