Prototype for reworking the Scene class. #240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sahilshekhawat Do you want to handle this further or shall I? |
|
Should I add more commits here consisting of what I have already done on #196 and more? |
|
I am gonna take your changes as is and raise another PR. This is the last issue blocking the release. I want to fix it as soon as possible. |
|
Please preserve commit history if possible. |
|
Yes, it will be. I have fetched this PR and will push that branch itself. |
| @system.setter | ||
| def system(self, new_system): | ||
|
|
||
| if new_system is not None and not isinstance(new_system, System): |
There was a problem hiding this comment.
You don't need to explicitly check if it is not None.
There was a problem hiding this comment.
Can you please review #242 instead of this , I have added some extra things to this PR.
|
I'll close this one. Thanks for using it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sahilshekhawat This is my rework of the scene class that should allow you to complete the PR you were working on. Can you pull the branch, add the addtional things you were working on in #196 on top of these commits and send in a new PR?