Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks the travis conda setup. #233

Merged
merged 3 commits into from
Jun 14, 2015
Merged

Tweaks the travis conda setup. #233

merged 3 commits into from
Jun 14, 2015

Conversation

moorepants
Copy link
Member

Fixes #160

@oliverlee Can you check over these changes and see if you are fine with them? It reintroduces testing on the range of deps we support.

  • There are no merge conflicts.
  • If there is a related issue, a reference to that issue is in the
    commit message.
  • Unit tests have been added for the bug. (Please reference the issue #
    in the unit test.)
  • The tests pass both locally (run nosetests) and on Travis CI.
  • The code follows PEP8 guidelines. (use a linter, e.g.
    pylint, to check your code)
  • The bug fix is documented in the Release
    Notes
    .
  • The code is backwards compatible. (All public methods/classes must
    follow deprecation cycles.)
  • All reviewer comments have been addressed.

@moorepants moorepants added this to the 0.3.0 Release milestone Jun 14, 2015
@oliverlee
Copy link
Contributor

Looks good assuming tests pass.

@oliverlee
Copy link
Contributor

You need to change the versions

Hint: the following packages conflict with each other:

  • numpy 1.6.2*
  • theano 0.6*

@moorepants
Copy link
Member Author

conda install sympy=0.7.4 will install 0.7.4.1. The single = in conda gets the lastest version in that series, in this case the latest version of 0.7.4. Is that what you are referring to?

@oliverlee
Copy link
Contributor

yes

@moorepants
Copy link
Member Author

Ok, you can merge if you think this is good now.

oliverlee added a commit that referenced this pull request Jun 14, 2015
Tweak the travis conda setup
@oliverlee oliverlee merged commit ec139f0 into pydy:master Jun 14, 2015
@moorepants moorepants deleted the travis branch June 15, 2015 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup Travis testing with more testing options
2 participants