Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setuptools >= 8 is now required and used on Travis with pip >=6. #166

Merged
merged 2 commits into from
May 12, 2015
Merged

setuptools >= 8 is now required and used on Travis with pip >=6. #166

merged 2 commits into from
May 12, 2015

Conversation

moorepants
Copy link
Member

Fixes issue #120.

If development versions of SymPy are used to test PyDy one must now use new
SymPy versions with PEP440 compliant version identifiers. Older SymPy dev
version numbers that end in -git will now fail with a ValueError unless
setuptools < 8.0 are used.

  • There are no merge conflicts.
  • If there is a related issue, a reference to that issue is in the
    commit message.
  • Unit tests have been added for the bug. (Please reference the issue #
    in the unit test.)
  • The tests pass both locally (run nosetests) and on Travis CI.
  • The code follows PEP8 guidelines. (use a linter, e.g.
    pylint, to check your code)
  • The bug fix is documented in the Release
    Notes    .
  • The code is backwards compatible. (All public methods/classes must
    follow deprecation cycles.)
  • All reviewer comments have been addressed.

@moorepants
setuptools >= 8 is now required and used on Travis with pip >=6.
99df541 
Fixes issue pydy#120.

If development versions of SymPy are used to test PyDy one must now use new
SymPy versions with PEP440 compliant version identifiers. Older SymPy dev
version numbers that end in `-git` will now fail with a ValueError unless
setuptools < 8.0 are used.
@moorepants
Copy link
Member Author

@pydy/pydy-developers This PR needs a review. Thanks.

@moorepants moorepants added this to the 0.3.0 Release milestone May 12, 2015
@sahilshekhawat
Copy link
Member

This is good to go in too.

@moorepants
Copy link
Member Author

Thanks, merging.

moorepants added a commit that referenced this pull request May 12, 2015
@moorepants
Merge pull request #166 from moorepants/issue-120
8d0e384 
setuptools >= 8 is now required and used on Travis with pip >=6.
@moorepants moorepants merged commit 8d0e384 into pydy:master May 12, 2015
@moorepants moorepants deleted the issue-120 branch May 12, 2015 17:35
@moorepants moorepants mentioned this pull request Jun 12, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@moorepants @sahilshekhawat