Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specify the target filter in setDiscoverTargets #8742

Merged
merged 1 commit into from
Aug 4, 2022
Merged

fix: specify the target filter in setDiscoverTargets #8742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: specify the target filter in setDiscoverTargets 
To stay compatible with the next version of Chromium.
See https://chromedevtools.github.io/devtools-protocol/tot/Target/#method-setDiscoverTargets
  • Loading branch information
@OrKoN
OrKoN committed Aug 4, 2022
commit 0db60ea8966502ce60a604463bc3927da97b73d2
7 changes: 6 additions & 1 deletion src/common/ChromeTargetManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,12 @@ export class ChromeTargetManager extends EventEmitter implements TargetManager {
this.#connection.on('sessiondetached', this.#onSessionDetached);
this.#setupAttachmentListeners(this.#connection);

this.#connection.send('Target.setDiscoverTargets', {discover: true});
// TODO: remove `as any` once the protocol definitions are updated with the
// next Chromium roll.
this.#connection.send('Target.setDiscoverTargets', {
discover: true,
filter: [{type: 'tab', exclude: true}, {}],
} as any);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy to type it out as an explicit type but I guess any is okay as it's only till the next roll

}

async initialize(): Promise<void> {
Expand Down