fix: specify the target filter in setDiscoverTargets #8742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To stay compatible with the next version of Chromium. See https://chromedevtools.github.io/devtools-protocol/tot/Target/#method-setDiscoverTargets
OrKoN
commented
Aug 4, 2022
| this.#connection.send('Target.setDiscoverTargets', { | ||
| discover: true, | ||
| filter: [{type: 'tab', exclude: true}, {}], | ||
| } as any); |
There was a problem hiding this comment.
happy to type it out as an explicit type but I guess any is okay as it's only till the next roll
jrandolf-2
approved these changes
Aug 4, 2022
YusukeIwaki
added a commit
to YusukeIwaki/puppeteer-ruby
that referenced
this pull request
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To stay compatible with the next version of Chromium.
See https://chromedevtools.github.io/devtools-protocol/tot/Target/#method-setDiscoverTargets